Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Aphasia disability #6181

Merged
merged 14 commits into from
Jan 3, 2025
Merged

Conversation

KefirTT
Copy link
Contributor

@KefirTT KefirTT commented Nov 15, 2024

Описание

Добавляет в билд Абхазию афазию как дизабилку, которую можно выбить в генетике или выбрать при создании персонажа. Афазия не позволяет говорить на общегалактическом языке, однако все еще дает возможность понимать его.

Ссылка на предложение/Причина создания ПР

https://discord.com/channels/617003227182792704/755125334097133628/1305227174768414780

Демонстрация изменений

Без имени-1
Сверху - от лица таяры, снизу - от лица хумана

Тесты

все проверил, на слово поверьте пж

code/game/dna/genes/disabilities.dm Outdated Show resolved Hide resolved
code/game/dna/genes/disabilities.dm Outdated Show resolved Hide resolved
code/game/dna/genes/disabilities.dm Outdated Show resolved Hide resolved
code/game/dna/genes/disabilities.dm Outdated Show resolved Hide resolved
code/game/dna/genes/disabilities.dm Outdated Show resolved Hide resolved
Antoonij
Antoonij previously approved these changes Nov 16, 2024
@Antoonij Antoonij added Has Approve Have been approved by somebody from Review Team and awaiting for one more approve and removed Has Approve Have been approved by somebody from Review Team and awaiting for one more approve labels Nov 16, 2024
Copy link
Contributor

@Antoonij Antoonij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все же, нуждается в доработке.

  1. Привести это в единый вид (датум набора языков, как на тг) - опционально, но решило бы наперед все проблемы и проблему, что указана во 2 пункте + привелось бы в общий вид с боргами и их списком
  2. Починить часть кода, связанную с получением дефолтного языка (кукла может продолжать говорить, даже если язык не находится в списке, а просто является дефолтным)

@Antoonij Antoonij dismissed their stale review November 18, 2024 10:06

требуется доработка.

Copy link
Member

@PlayerUnknown14 PlayerUnknown14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Йеп.

code/game/dna/genes/disabilities.dm Outdated Show resolved Hide resolved
Copy link
Contributor

@Antoonij Antoonij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

теперь выглядит и работает хорошо, без лишних рефакторов языков.
image

@Antoonij Antoonij added the Has Approve Have been approved by somebody from Review Team and awaiting for one more approve label Jan 2, 2025
Copy link
Member

@PlayerUnknown14 PlayerUnknown14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Йеп.

@PlayerUnknown14 PlayerUnknown14 added this pull request to the merge queue Jan 3, 2025
Merged via the queue into ss220-space:master220 with commit 99fa04a Jan 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Has Approve Have been approved by somebody from Review Team and awaiting for one more approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants